Revert "test: change duration_ms to duration" #7214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d413378.
2 tasks
addaleax
added
test
|
If this something that already has lead to confusion multiple times, maybe adding an inline comment to explain it (or reference e.g. this PR) is a good idea? |
|
yep, was just thinking that, will do next PR |
|
LGTM from me then |
|
LGTM |
|
Can this be closed in favor of #7216? |
|
yeah, sure, both commits are there, thanks |
|
Ugh... yes, you're right, I thought this looked familiar but completely zoned on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoes the change made @ #7133
I'm pretty sure we've had this discussion at least twice on GitHub already but I can't find either record unfortunately. Sorry I'm just catching up and saw this PR only now.
"duration_ms" is a TAP thing and yes it's confusing and doesn't read well but you have to interpret it as "duration including milliseconds", so it's "seconds.milliseconds". When you change it, TAP parsers don't pick it up properly.
Compare the CI run that was done specifically for #7133 prior to merging:
With the run for that same slave machine done just one before without this change:
So now we've lost timing information, which is important when looking for timeouts (if you use the parsed results, I use the raw console but I know a lot of people prefer the former).